LilithSemi/vulcan
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(aarch64): fix vulcan-target on aarch64 darwin #4

Merged
theoparis merged 3 commits from theoparis/fix-aarch64-widen-non-leaf-fpr-owsrqzxsrztm into master 2026-08-24 03:58:38 +00:00
Conversation 1 Commits 3 Files changed 3 +149 -5
theoparis commented 2026-08-24 01:47:18 +00:00 (Migrated from github.com)
Copy link

Non-leaf functions only got 8 allocatable FPR registers (v8..v15), while non-leaf GPR functions got 14 (x19..x28 + x9..x12). Every aarch64 FP/vector operand is must_have_register (no spill-slot folding), so a non-leaf shader with several simultaneously live float/vector temporaries at one program point (loop header/merge point) could exceed the pool and hit spillCurrent's 'too many live params' bail-out (error.Unsupported), even on ordinary code such as vkcube's fragment shader on darwin/aarch64.

Mirror the existing GPR non-leaf widening by also offering the caller-saved v16..v23, which are already call-clobbered per the per-call clobber list.

Assisted-By: Claude Opus 4.8

Non-leaf functions only got 8 allocatable FPR registers (v8..v15), while non-leaf GPR functions got 14 (x19..x28 + x9..x12). Every aarch64 FP/vector operand is must_have_register (no spill-slot folding), so a non-leaf shader with several simultaneously live float/vector temporaries at one program point (loop header/merge point) could exceed the pool and hit spillCurrent's 'too many live params' bail-out (error.Unsupported), even on ordinary code such as vkcube's fragment shader on darwin/aarch64. Mirror the existing GPR non-leaf widening by also offering the caller-saved v16..v23, which are already call-clobbered per the per-call clobber list. Assisted-By: Claude Opus 4.8
RossComputerGuy (Migrated from github.com) approved these changes 2026-08-24 03:58:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
RossComputerGuy
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LilithSemi/vulcan!4
No description provided.