fix: emit valid code in codegen and add missing files to project manifest #2

Merged
Sivecano merged 2 commits from master into master 2026-07-11 19:48:17 +00:00
Sivecano commented 2026-07-10 13:46:18 +00:00 (Migrated from github.com)

to be very thorough: this PR does exactly what the title says.

  • add missing files to build.zig.zon. otherwise they won't get pulled by the zig build system, leading to zig fetch pulling a broken version of the project
  • fix the generator so it doesn't emit invalid zig code for methods with 0 arguments. This discards some unneeded arguments and avoids declaring unused variables
to be very thorough: this PR does exactly what the title says. * add missing files to build.zig.zon. otherwise they won't get pulled by the zig build system, leading to `zig fetch` pulling a broken version of the project * fix the generator so it doesn't emit invalid zig code for methods with 0 arguments. This discards some unneeded arguments and avoids declaring unused variables
RossComputerGuy (Migrated from github.com) requested changes 2026-07-11 00:43:49 +00:00
RossComputerGuy (Migrated from github.com) left a comment

Please follow conventional commits in your PR and commits title. Also, please provide a description explaining the bug that this PR resolves.

Please follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) in your PR and commits title. Also, please provide a description explaining the bug that this PR resolves.
Sivecano commented 2026-07-11 11:23:56 +00:00 (Migrated from github.com)

here you go

here you go
RossComputerGuy (Migrated from github.com) reviewed 2026-07-11 18:32:43 +00:00
RossComputerGuy (Migrated from github.com) left a comment

Code looks good, still need to rewrite commit titles to follow commit convention. PR title also should follow commit convention (small nit: typo in the PR title).

Code looks good, still need to rewrite commit titles to follow commit convention. PR title also should follow commit convention (small nit: typo in the PR title).
Sivecano commented 2026-07-11 18:56:41 +00:00 (Migrated from github.com)

ah, forgot to push.

ah, forgot to push.
RossComputerGuy (Migrated from github.com) approved these changes 2026-07-11 18:59:10 +00:00
RossComputerGuy (Migrated from github.com) left a comment

Thank you for contributing

Thank you for contributing
Sign in to join this conversation.
No description provided.